Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting WalletConnect to connect to Metamask #41

Open
Toporin opened this issue May 30, 2022 · 3 comments
Open

Consider supporting WalletConnect to connect to Metamask #41

Toporin opened this issue May 30, 2022 · 3 comments

Comments

@Toporin
Copy link

Toporin commented May 30, 2022

we have recently developped eth-walletconnect-keyring, an implementation of MetaMask's Keyring interface that uses the WalletConnect protocol to connect a (hardware) wallet to Metamask. A beta release of Metamask with this solution is available here for testing:
https://github.com/Toporin/metamask-extension/releases/tag/v10.13.0-WC

This is an early proof-of-concept, but it would allow any wallet (hardware/software) that supports the WalletConnect protocol to connect to Metamask. It is a standard and neutral solution, quite simple and without USB/hardware requirements, so we hope that the Metamask team would be more willing to integrate it (like they did with the QR-code approach supported by multiple vendors).

Here is a short demo showing how to connect a wallet to Metamask through the eth-wallet-keyring plugin. When using the WalletConnect option, a new tab opens with a react app that will handle the actual WalletConect connection. In this demo, we use a local server (for development only), in production, the react app is currently hosted on github-page.

Would you be interested to check this approach, and maybe collaborate with us to push this solution forward? The more people involved, the greater the chance to have a pull request accepted!

Everything is open source, questions, comments and pull requests are welcome!

@benma
Copy link
Contributor

benma commented Jun 1, 2022

Sounds like a good idea - it would reduce/remove the burden on Metamask to maintain many keyrings.

Did you already propose it to Metamask?

@Toporin
Copy link
Author

Toporin commented Jun 1, 2022

Sounds like a good idea - it would reduce/remove the burden on Metamask to maintain many keyrings.

Did you already propose it to Metamask?

I have not suggested this idea to Metamask yet, I wanted to see first if there was any interest among users and wallet providers. I have contacted a few other projects (CoolWallet and D'Cent), so I will wait a few days for their feedback then I will create a pull request for Metamask, probably beginning of next week. Your support would be greatly appreciated!

@Toporin
Copy link
Author

Toporin commented Jun 8, 2022

FYI, I just created a pull request to Metamask to initiate the discussion:
MetaMask/metamask-extension#14895

You are welcome to participate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants