Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Daily average to maintain" calculated based on incorrect number of days #19

Open
a1sop0s opened this issue Nov 7, 2024 · 11 comments

Comments

@a1sop0s
Copy link

a1sop0s commented Nov 7, 2024

The recommended daily average to maintain is calculated using incorrect days all up until opening "Select your working days", disabling custom days and clicking submit. When re-enabling custom days, the hours seem to be correct.
This seems to occur every new workday.

This is especially noticeable when you've customised your working days to be less or more than 20 days.
I do sometimes do work on weekends, despite not having configured them as working days, could this be affecting the daily average incorrectly as well?

MacOS Sonoma 14.6.1
Version 0.8.0 (App Store latest)

@BirjuVachhani
Copy link
Owner

Hey @a1sop0s, Thanks for reporting the issue. Could you please share screenshot of what you're seeing and why you think it is wrong? Share details on hours left/daily average, working days left, etc.

Also, turn on the option Show Remaining in settings and see if it looks correct to you. I've been using it since I made it and I haven't run into the same issue despite having similar workflow as you.

@a1sop0s
Copy link
Author

a1sop0s commented Nov 8, 2024

If I remember correctly, the show remaining text was the exact same as the average to maintain. I'll get back to you with the details as soon as it happens again.
This morning I had custom days disabled and the hours were correct.

@a1sop0s
Copy link
Author

a1sop0s commented Nov 11, 2024

Hi @BirjuVachhani. This has just happened again. The initial recommended average (4h 33min), when multiplied by days left and then added to the previous hours, sums up to 87.5h, which is 8.5h short from the target hours.
image
After going to edit custom days and directly pressing save (without changing any values), the recommended hours were corrected to 4h and 51min, which is quite a bit closer to the target hours.
image

image

It's important to note that during these screenshots, Toggl was already running, but not backwards 😅

@a1sop0s
Copy link
Author

a1sop0s commented Nov 11, 2024

I've just realised that perhaps this could be an issue with Target Mate not recognising that a working day has been started? And once saving the custom days, Target Mate is refreshed?

@BirjuVachhani
Copy link
Owner

BirjuVachhani commented Nov 13, 2024

In your 1st and 3rd screenshot, notice the working days going from 6 to 7. A day is reduced in the 3rd screenshot without any new hours being added. I think that's why it increased daily average. What were your selection of days before? I wouldn't change it from 6 to 7 without any changes! (Keep in mind that the day number shown is the current working day with needs to be accounted for in the calculation!)

After going to edit custom days and directly pressing save (without changing any values), the recommended hours were corrected to 4h and 51min, which is quite a bit closer to the target hours.

I tried reproducing it but it does not change for me.

@a1sop0s
Copy link
Author

a1sop0s commented Nov 13, 2024

It is imperative that another day has rolled around and custom days are enabled before the next day for this bug to appear.
I keep the days the same, 5 days a week, every week. Average hours set to 6, total hours set to 96. No changes between screenshots. My 2nd screenshot is the state before pressing save, with no edits.

It seems like the current day isn't properly accounted for until I press save on custom days.

@BirjuVachhani
Copy link
Owner

What version of Target Mate are you on?

@a1sop0s
Copy link
Author

a1sop0s commented Nov 14, 2024

0.8.0

@BirjuVachhani
Copy link
Owner

I see. I am not able to reproduce it on my side even though I have very similar setup. I am not sure if this could be a bad state. Has this happened in previous month?

Would try logging out and logging in again (Just to see if it was in a bad state somehow!)?

@a1sop0s
Copy link
Author

a1sop0s commented Nov 15, 2024

This has happened every day I've had custom days enabled, I believe since I got Target Mate. Took me a while to realise something was off.
I'll try logging out now and get back to you on Monday.

@BirjuVachhani
Copy link
Owner

Please logout and then uninstall and reinstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants