Require keeping scroll in your hand during teleport #26
Conversation
|
@FM-96 Thanks for this contribution. I'll have to think about how this should work. My gut reaction is that the scroll should be removed from the player's inventory before the teleport starts, and then can be re-added if the teleport fails. I may feel differently about the solution after some thinking, so I'll leave this open for now. |
|
That seems unnecessarily complicated to me, to be honest. (And also opens up other issues, like what if the player picks up items after starting the teleport and has no more space in their inventory when you want to re-add the scroll?) |
|
@FM-96 then the scroll will fall onto the ground, just like any item would if you tried to |
|
Hey @BLuFeNiX, it's been a while; I wanted to ask if there's any update on this? Also, if I changed this so there was a config option for requiring you to hold the scroll the entire time, would you merge it then? That way, whenever you get around to it, you could still change it to work like you described if the setting is turned off, but we'd also have this way as an option (because I think it works fairly well, and I also still think the limitation makes sense). |
|
@FM-96 I still think having the scroll removed from the inventory prior to TP is the right way to mitigate this, however, if you make holding the scroll configurable and leave the current behavior as the default setting, I will merge the changes. |
|
closing due to lack of discussion. Feel free to open a new PR if this still interests anyone. |
Players now need to continuously hold the Scroll of Warp in their hands during the teleport delay. Putting the Scroll away will cancel the teleport.
This fixes #21. I went with this option for dealing with the issue because it was the easiest for me to implement, and it also seemed to make a lot of sense.
While this does change the plugin's behaviour somewhat, players can still move the Scroll into their offhand after activating it and then use their mainhand for e.g. building or fighting off threats while the teleport charges, so it feels like a reasonable compromise.