Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Hide related posts options for block themes #98190

Open
3 tasks
lsl opened this issue Jan 10, 2025 · 1 comment · May be fixed by Automattic/jetpack#41075
Open
3 tasks

Settings: Hide related posts options for block themes #98190

lsl opened this issue Jan 10, 2025 · 1 comment · May be fixed by Automattic/jetpack#41075
Assignees
@okmttdhr
Labels
[Experiment] AI labels added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Jetpack Connection Errors [Feature] Site Settings All other general site settings.

Comments

@lsl
Copy link
Contributor

lsl commented Jan 10, 2025

Reading settings in wp-admin show related posts options. These options are only relevant for classic themes and should be hidden when the site is using a block theme. These options are also Jetpack options that show both in reading settings and Jetpack for atomic sites. I think we should also hide the Jetpack option while we're at it. (I believe it might be the same code on the atomic side, simple side we may do something different)

  • Hide these options when the site is not using a classic theme - simple sites
  • Hide these options when the site is not using a classic theme - atomic sites
  • Hide the options in Jetpack when the site is not using a classic theme - all Jetpack sites, including atomic

Image
Image
@github-actions github-actions bot added the [Feature Group] Appearance & Themes Features related to the appearance of sites. label Jan 10, 2025
@github-actions GitHub Actions
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Appearance & Themes: The issue involves settings related to themes, particularly regarding the visibility of related posts options in block themes versus classic themes.
  • [Feature] Jetpack Connection Errors: The issue mentions Jetpack options, indicating that there might be a connection or configuration aspect related to Jetpack in the context of themes.
  • [Feature] Site Settings: The body discusses altering settings in the admin panel, specifically how related posts options should be managed based on the type of theme in use.

@lsl lsl modified the milestone: Untangling: Settings Jan 10, 2025
@okmttdhr okmttdhr self-assigned this Jan 14, 2025
@okmttdhr okmttdhr linked a pull request Jan 15, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okmttdhr okmttdhr

Labels
[Experiment] AI labels added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Jetpack Connection Errors [Feature] Site Settings All other general site settings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Related Posts: Hide settings in block themes Automattic/jetpack
2 participants
@lsl @okmttdhr