Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect kwargs handling in visualize_frame #108

Open
2 tasks done
IkumaUchida opened this issue Aug 9, 2023 · 0 comments
Open
2 tasks done

Incorrect kwargs handling in visualize_frame #108

IkumaUchida opened this issue Aug 9, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@IkumaUchida
Copy link
Collaborator

Search before asking

  • I have searched the SoccerTrack issues and found no similar bug report.

SoccerTrack Component

Other

Bug

When visualizing codf, if the information of the marker of home_team is edited from the argument, it is also reflected in the marker information of away_team.

Environment

No response

Minimal Reproducible Example

For example, if home_kwargs is set as follows, the output will be as follows

...

codf.visualize_frame(1, 
                ball_key="BALL", 
                home_kwargs={"zorder": 10, "ms": 10, "markerfacecolor": "w"},
)

...

codf_outpy

Additional

Simply modify the visualize_frame function in cofinatesdataframe.py slightly.

before

        _away_kwargs = merge_dicts(
            _marker_kwargs,
            {"zorder": 10, "ms": 10, "markerfacecolor": "r"},
            marker_kwargs,
            home_kwargs,
        )

after

        _away_kwargs = merge_dicts(
            _marker_kwargs,
            {"zorder": 10, "ms": 10, "markerfacecolor": "r"},
            marker_kwargs,
            away_kwargs,
        )

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@IkumaUchida IkumaUchida added the bug Something isn't working label Aug 9, 2023
@AtomScott AtomScott self-assigned this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants